-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync updates from upstream #510
Conversation
These changes are just additions, causing no conflict with existing code. Markers like `GSG code starts/ends` are kept to make it easier to identify the added code and distinguish it with other changes between 0.5.0 and 0.5.1, as well as GSG's other proposed changes. Co-authored-by: Greg Grunberg <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #510 +/- ##
==========================================
+ Coverage 78.05% 78.95% +0.90%
==========================================
Files 17 19 +2
Lines 4196 4400 +204
==========================================
+ Hits 3275 3474 +199
- Misses 921 926 +5 ☔ View full report in Codecov by Sentry. |
Removed code conflicting about `Matrix_to_dictionary` and `inspect.getfullargspec`. Co-authored-by: Greg Grunberg <[email protected]>
CI is green for |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
The changes to test outputs of The changes to test outputs of Will investigate later. The current green CI is a delusion for now. The visual diff is at: https://app.reviewnb.com/pygae/galgebra/commit/33a33fbefc67a480e7f0565273cc16b0e34f8d09/ |
Co-authored-by: Alan Bromborsky <[email protected]>
Co-authored-by: Greg Grunberg <[email protected]>
They are put into examples/primer, and `GAlgebraOutput.ipynb` is renamed to `gprint.ipynb`, and the rest are ensured to be in lowercase. Co-authored-by: Greg Grunberg <[email protected]>
Addresses #505 .
This PR aims to:
GSG code starts/ends
will be kept to make it easier to identify the added code and distinguish it with other changes between 0.5.0 and 0.5.1, as well as GSG's other proposed changesadd documentations for new APIs(there are basic docs, I choose to use follow-up PRs to improve)The goal here is to make it a foundation for merging other people's work, and avoid accidentally rolling back previous work (check v0.5.0...v0.5.1 to decide what to keep when there is code conflict).
The strategy is to add them and fix them file by file.
TODOs:
mv
lt
gprinter
GAlgebraInit
(renamed toprimer
)GAlgebraOutput.ipynb
is renamed togprint.ipynb
, and the rest are ensured to be in lowercase.)lin_tran_check
test_gsg_undual_etc.ipynb