-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge the new printer by abrombo #39
Conversation
Co-authored-by: Alan Bromborsky <[email protected]>
Co-authored-by: Alan Bromborsky <[email protected]>
There's one failed test under Python 3 which is not expected (it works locally), but all failures under Python 2.7 are expected because the original implementation from abrombo didn't consider Python 2 compatibility but I intend to keep it compatible, at least for a while. Will fix later. |
Notebooks need regenerating |
@@ -92,6 +96,8 @@ def derivatives_in_prolate_spheroidal_coordinates(): | |||
A = ps3d.mv('A','vector',f=True) | |||
B = ps3d.mv('B','bivector',f=True) | |||
|
|||
print('#Derivatives in Prolate Spheroidal Coordinates') | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind making a new PR with just the changes to this file (and the notebook changes entailed)? I remember being confused by the output without these dividers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll have to do that even later tonight (need a full dev environment back home)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to do this any time soon, just might be nice to pick up at some point.
This should be superseded by #510 which merged gprinter from upstream. Feel free to reopen if there are remaining issues. |
Fixes #38 .