Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge the new printer by abrombo #39

Closed
wants to merge 2 commits into from
Closed

Merge the new printer by abrombo #39

wants to merge 2 commits into from

Conversation

utensil
Copy link
Member

@utensil utensil commented Oct 7, 2019

Fixes #38 .

utensil and others added 2 commits October 7, 2019 21:54
Co-authored-by: Alan Bromborsky <[email protected]>
Co-authored-by: Alan Bromborsky <[email protected]>
@utensil
Copy link
Member Author

utensil commented Oct 7, 2019

There's one failed test under Python 3 which is not expected (it works locally), but all failures under Python 2.7 are expected because the original implementation from abrombo didn't consider Python 2 compatibility but I intend to keep it compatible, at least for a while. Will fix later.

@eric-wieser
Copy link
Member

Notebooks need regenerating

@eric-wieser eric-wieser added the component: printer string, latex, and ansi escape printing label Apr 30, 2020
@@ -92,6 +96,8 @@ def derivatives_in_prolate_spheroidal_coordinates():
A = ps3d.mv('A','vector',f=True)
B = ps3d.mv('B','bivector',f=True)

print('#Derivatives in Prolate Spheroidal Coordinates')

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind making a new PR with just the changes to this file (and the notebook changes entailed)? I remember being confused by the output without these dividers.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have to do that even later tonight (need a full dev environment back home)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to do this any time soon, just might be nice to pick up at some point.

@utensil utensil added this to the 0.6.0 milestone May 15, 2024
@utensil
Copy link
Member Author

utensil commented May 15, 2024

This should be superseded by #510 which merged gprinter from upstream. Feel free to reopen if there are remaining issues.

@utensil utensil closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: printer string, latex, and ansi escape printing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conversion of Printing to Python 3
2 participants