-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update config parameters to match latest OIDC release and fix typos. … #2569
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, and good catch for the typos for PKCDMethod
and UserInfoSignedResposeAlg
.
I added some in-line comments with suggestions to fix some minor issues. Feel free to amend your commit, and to reply if something is not clear for you.
Thank you!
@smortex Thanks for you comments. I have made an extra commit that addresses Integer, String and Apache::OnOff data-types in the rest of the file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job. There are still 2 open comments where I think it is worth improving. I was not providing many details, so added more context of the reason why I am suggesting these changes.
Feel free to review them and tell me if you spot something that seems wrong.
Thank you!
@smortex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks awesome! Thank you for your work on this.
This looks complete to me, but I'll let other people review this PR and merge it if they feel it's ready.
Thanks for this! There are typos in both REFERENCE.md and oidcsettings.php at the line: |
Co-authored-by: Romain Tartière <[email protected]>
5e9f7b5
to
9778de4
Compare
FYI, this introduces a small breakage. |
Summary
Update Apache::OIDCSettings parameters to match latest mod_auth_openidc release.
Related Issues (if any)
Fixes #2567 #2566