Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config parameters to match latest OIDC release and fix typos. … #2569

Merged
merged 5 commits into from
Oct 23, 2024

Conversation

uoe-pjackson
Copy link
Contributor

Summary

Update Apache::OIDCSettings parameters to match latest mod_auth_openidc release.

  • Add parameters previously not included
  • Fix typos in paramater names
  • Update exisiting datatypes to match updated OIDC usage

Related Issues (if any)

Fixes #2567 #2566

Copy link
Collaborator

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, and good catch for the typos for PKCDMethod and UserInfoSignedResposeAlg.

I added some in-line comments with suggestions to fix some minor issues. Feel free to amend your commit, and to reply if something is not clear for you.

Thank you!

types/oidcsettings.pp Outdated Show resolved Hide resolved
types/oidcsettings.pp Outdated Show resolved Hide resolved
types/oidcsettings.pp Outdated Show resolved Hide resolved
types/oidcsettings.pp Outdated Show resolved Hide resolved
types/oidcsettings.pp Outdated Show resolved Hide resolved
types/oidcsettings.pp Outdated Show resolved Hide resolved
types/oidcsettings.pp Outdated Show resolved Hide resolved
types/oidcsettings.pp Outdated Show resolved Hide resolved
types/oidcsettings.pp Outdated Show resolved Hide resolved
types/oidcsettings.pp Outdated Show resolved Hide resolved
uoe-pjackson added a commit to uoe-pjackson/puppetlabs-apache that referenced this pull request Sep 23, 2024
@uoe-pjackson
Copy link
Contributor Author

@smortex Thanks for you comments. I have made an extra commit that addresses Integer, String and Apache::OnOff data-types in the rest of the file.

Copy link
Collaborator

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. There are still 2 open comments where I think it is worth improving. I was not providing many details, so added more context of the reason why I am suggesting these changes.

Feel free to review them and tell me if you spot something that seems wrong.

Thank you!

types/oidcsettings.pp Outdated Show resolved Hide resolved
types/oidcsettings.pp Outdated Show resolved Hide resolved
@uoe-pjackson
Copy link
Contributor Author

uoe-pjackson commented Sep 24, 2024

@smortex
Woops, I had overlooked those two suggestions. I've updated as you suggested. Thanks for you patience!

smortex
smortex previously approved these changes Sep 24, 2024
Copy link
Collaborator

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks awesome! Thank you for your work on this.

This looks complete to me, but I'll let other people review this PR and merge it if they feel it's ready.

@pebtron
Copy link
Contributor

pebtron commented Oct 2, 2024

Thanks for this! There are typos in both REFERENCE.md and oidcsettings.php at the line:
Optional['SessionCookieChunkSize'] => Intege[-1],

@malikparvez malikparvez merged commit e0c4af7 into puppetlabs:main Oct 23, 2024
41 of 43 checks passed
@gcoxmoz
Copy link
Contributor

gcoxmoz commented Nov 8, 2024

FYI, this introduces a small breakage. UserInfoRefreshInterval went from Integer to Pattern and so we have to quote integer as strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using PrivateKeyFiles parameter in oidc_settings causes unrecognized key error
5 participants