Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update types/oidcsettings UserInfoRefreshInterval to allow Integers again #2578

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

gcoxmoz
Copy link
Contributor

@gcoxmoz gcoxmoz commented Nov 9, 2024

Summary

#2569 / commit 90f7482 swapped UserInfoRefreshInterval from an Integer to a Pattern that was (string representations of numbers) || (some magic strings). This breaks configs that had integers in play.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

#2569

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@gcoxmoz gcoxmoz requested review from bastelfreak, ekohl, smortex and a team as code owners November 9, 2024 04:21
smortex
smortex previously approved these changes Nov 10, 2024
@smortex smortex added the bugfix label Nov 10, 2024
@malikparvez malikparvez merged commit 3fa5260 into puppetlabs:main Nov 18, 2024
42 checks passed
@gcoxmoz gcoxmoz deleted the fix-UserInfoRefreshInterval branch November 18, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants