Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-merge patch level dependencies in component renovate config #101

Merged
merged 3 commits into from
May 24, 2024

Conversation

HappyTetrahedron
Copy link
Contributor

Checklist

  • The PR has a meaningful title. It will be used to auto generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.

@HappyTetrahedron HappyTetrahedron added the enhancement New feature or request label May 22, 2024
@HappyTetrahedron
Copy link
Contributor Author

HappyTetrahedron commented May 22, 2024

One open question: This will work as expected (automerge only if tests pass) IFF the github repository is configured to require checks to pass before allowing a PR merge. How sure are we that all component repos are configured that way?
(answer: not sure enough.)

@HappyTetrahedron HappyTetrahedron force-pushed the feat/automerge-patch branch 2 times, most recently from ba76d01 to f720b4e Compare May 22, 2024 15:13
@HappyTetrahedron
Copy link
Contributor Author

HappyTetrahedron commented May 22, 2024

We will need something like the renovate-approve app to auto approve renovate PRs; otherwise the GitHub "require review" feature will prevent them from being merged.

@HappyTetrahedron HappyTetrahedron requested a review from a team May 24, 2024 08:24
@HappyTetrahedron
Copy link
Contributor Author

projectsyn/component-lieutenant#96 got merged
projectsyn/component-lieutenant#95 did not get automerged (0.x version)
successful test!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants