Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust component template tests to allow additional Cookiecutter context keys #970

Merged
merged 1 commit into from
May 27, 2024

Conversation

simu
Copy link
Member

@simu simu commented May 27, 2024

This allows us to add new Cookiecutter context keys to the template without breaking the tests. The adjusted test just checks that all the known context keys are present, but doesn't fail if there are any additional context keys.

Discovered after projectsyn/commodore-component-template#101 got merged.

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update tests.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency, internal
    as they show up in the changelog
  • Link this PR to related issues.

@simu simu added the ignore Ignore PR in changelog label May 27, 2024
@simu simu requested a review from a team as a code owner May 27, 2024 09:36
@simu simu requested a review from a team May 27, 2024 09:36
@simu simu merged commit faad243 into master May 27, 2024
23 checks passed
@simu simu deleted the fix/update-template-tests branch May 27, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore Ignore PR in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants