Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update @primer/octicons-react to 19.14.0 #5422

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

chore(deps): update @primer/octicons-react to 19.14.0 #5422

wants to merge 6 commits into from

Conversation

joshblack
Copy link
Member

Closes #

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 12, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: a31e006

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Dec 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 103.57 KB (+0.23% 🔺)
packages/react/dist/browser.umd.js 104.02 KB (+0.34% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-5422 December 12, 2024 16:13 Inactive
@primer primer bot temporarily deployed to github-pages December 12, 2024 16:32 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5422 December 12, 2024 16:32 Inactive
@langermank langermank mentioned this pull request Dec 17, 2024
Merged
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@lukasoppermann lukasoppermann marked this pull request as ready for review December 18, 2024 12:58
@lukasoppermann lukasoppermann requested review from a team as code owners December 18, 2024 12:58
@lukasoppermann lukasoppermann added the skip changeset This change does not need a changelog label Dec 18, 2024
jonrohan
jonrohan reviewed Dec 18, 2024
View reviewed changes
packages/react/src/NavList/__snapshots__/NavList.test.tsx.snap
style="display: inline-block; user-select: none; vertical-align: text-bottom; overflow: visible;"
overflow="visible"
style="vertical-align: text-bottom;"
sx="[object Object]"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this sx be inlining like this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sure not, but how do we fix it?

@langermank
Copy link
Contributor

I think we should hold off on merging this until we can address the strange sx issue. I bumped PRC to 19.13.0 so we're a bit more up to date in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasoppermann lukasoppermann lukasoppermann left review comments

@jonrohan jonrohan jonrohan left review comments

@mperrotti mperrotti Awaiting requested review from mperrotti mperrotti is a code owner automatically assigned from primer/design-reviewers

@langermank langermank Awaiting requested review from langermank

@TylerJDev TylerJDev Awaiting requested review from TylerJDev

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
do not merge integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joshblack @langermank @jonrohan @lukasoppermann