Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement code connect for segmentedControl and heading #4849

Merged

Conversation

lukasoppermann
Copy link
Contributor

@lukasoppermann lukasoppermann commented Aug 14, 2024

Is this the correct code output?

CleanShot 2024-08-14 at 11 28 22@2x

Also @joshblack I think the SegmentedContorl has the same issue with leadingIcon where it does only accept a function but not an element. Can we fix that?

@lukasoppermann lukasoppermann requested a review from a team as a code owner August 14, 2024 09:29
Copy link

changeset-bot bot commented Aug 14, 2024

⚠️ No Changeset found

Latest commit: 995d29f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lukasoppermann lukasoppermann self-assigned this Aug 14, 2024
Copy link
Contributor

Uh oh! @lukasoppermann, the image you shared is missing helpful alt text. Check your pull request body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

Copy link
Contributor

Uh oh! @lukasoppermann, the image you shared is missing helpful alt text. Check your pull request body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

@lukasoppermann lukasoppermann force-pushed the @lukasoppermann/figma-code-connect-segmentedControl branch from 26e7b2b to c4659ff Compare August 14, 2024 09:31
Copy link
Contributor

github-actions bot commented Aug 14, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.27 KB (0%)
packages/react/dist/browser.umd.js 104.59 KB (0%)

@joshblack
Copy link
Member

Also @joshblack I think the SegmentedContorl has the same issue with leadingIcon where it does only accept a function but not an element. Can we fix that?

@lukasoppermann definitely! I think it should be just as doable as the last component with this issue 👍 This could be a good issue for FR to take on (adding support for element to loadingIcon) since it should be quick

@lukasoppermann lukasoppermann changed the title Implement code connect for segmentedControl Implement code connect for segmentedControl and heading Aug 16, 2024
@primer primer deleted a comment from github-actions bot Sep 24, 2024
@lukasoppermann lukasoppermann added the skip changeset This change does not need a changelog label Sep 26, 2024
@lukasoppermann
Copy link
Contributor Author

After discussing with @siddharthkp we should keep the current behavior in the segmentedControl, as it otherwise leaves us open to unwanted customization in the icons.

I talked to Figma and they are working on a fix. We are hoping to get this in the next week, but until then this is blocked.

@lukasoppermann lukasoppermann added the 🚧 blocked Someone or something is preventing this from moving forward label Sep 26, 2024
@joshblack joshblack removed their request for review October 3, 2024 14:52
@lukasoppermann lukasoppermann force-pushed the @lukasoppermann/figma-code-connect-segmentedControl branch from 695d31c to af2239e Compare October 21, 2024 08:58
@lukasoppermann lukasoppermann force-pushed the @lukasoppermann/figma-code-connect-segmentedControl branch from 7f8f45a to 718f3d7 Compare November 18, 2024 14:52
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 18, 2024
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@lukasoppermann lukasoppermann force-pushed the @lukasoppermann/figma-code-connect-segmentedControl branch from 059a6c3 to e931ccf Compare December 17, 2024 13:37
Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go 🚀

@lukasoppermann lukasoppermann added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit 83386f4 Dec 19, 2024
42 checks passed
@lukasoppermann lukasoppermann deleted the @lukasoppermann/figma-code-connect-segmentedControl branch December 19, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants