-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement code connect for segmentedControl and heading #4849
Implement code connect for segmentedControl and heading #4849
Conversation
|
Uh oh! @lukasoppermann, the image you shared is missing helpful alt text. Check your pull request body. Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.
|
Uh oh! @lukasoppermann, the image you shared is missing helpful alt text. Check your pull request body. Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.
|
26e7b2b
to
c4659ff
Compare
size-limit report 📦
|
@lukasoppermann definitely! I think it should be just as doable as the last component with this issue 👍 This could be a good issue for FR to take on (adding support for element to loadingIcon) since it should be quick |
After discussing with @siddharthkp we should keep the current behavior in the segmentedControl, as it otherwise leaves us open to unwanted customization in the icons. I talked to Figma and they are working on a fix. We are hoping to get this in the next week, but until then this is blocked. |
695d31c
to
af2239e
Compare
7f8f45a
to
718f3d7
Compare
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
059a6c3
to
e931ccf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go 🚀
Is this the correct code output?
Also @joshblack I think the SegmentedContorl has the same issue with leadingIcon where it does only accept a function but not an element. Can we fix that?