Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Older devices are sending "gpc": 1 and this can't marshal. #4070

Merged
merged 8 commits into from
Dec 13, 2024
Merged

Older devices are sending "gpc": 1 and this can't marshal. #4070

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8776901
Older devices are sending "gpc": 1 and this can't marshal.
scr-oath Nov 21, 2024
639a1cf
Added test cases.
scr-oath Nov 22, 2024
4af0b37
Address SyntaxNode comments.
scr-oath Nov 22, 2024
5c8d751
Move use of gjson into jsonutil.
scr-oath Dec 2, 2024
61c786d
Use ptrutil in jsonutil too.
scr-oath Dec 2, 2024
e916199
Merge remote-tracking branch 'upstream/master' into fix-gpc
scr-oath Dec 11, 2024
8444c5c
Don't panic; return an error.
scr-oath Dec 11, 2024
8f05e81
Merge branch 'master' into fix-gpc
scr-oath Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions openrtb_ext/request_wrapper_test.go
View file
Open in desktop
scr-oath marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -2344,6 +2344,20 @@ func TestRegExtUnmarshal(t *testing.T) {
expectGPC: ptrutil.ToPtr("some_value"),
expectError: false,
},
{
name: `valid_gpc_json "1"`,
scr-oath marked this conversation as resolved.
Show resolved Hide resolved
regExt: &RegExt{},
extJson: json.RawMessage(`{"gpc": "1"}`),
expectGPC: ptrutil.ToPtr("1"),
expectError: false,
},
{
name: `valid_gpc_json 1`,
regExt: &RegExt{},
extJson: json.RawMessage(`{"gpc": 1}`),
expectGPC: ptrutil.ToPtr("1"),
expectError: false,
},
{
name: "malformed_gpc_json",
regExt: &RegExt{},
Expand Down
Loading