Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Older devices are sending "gpc": 1 and this can't marshal. #4070

Merged
merged 8 commits into from
Dec 13, 2024
Merged

Older devices are sending "gpc": 1 and this can't marshal. #4070

merged 8 commits into from
Dec 13, 2024

Conversation

scr-oath
Copy link
Contributor

@scr-oath scr-oath commented Nov 22, 2024 •
edited
Loading

@scr-oath scr-oath requested a review from SyntaxNode November 22, 2024 16:40
SyntaxNode
SyntaxNode previously approved these changes Nov 22, 2024
View reviewed changes
@SyntaxNode SyntaxNode self-assigned this Nov 22, 2024
@bsardo bsardo self-assigned this Nov 25, 2024
bsardo
bsardo reviewed Dec 11, 2024
View reviewed changes
util/jsonutil/forcestring.go Outdated Show resolved Hide resolved
openrtb_ext/request_wrapper.go Outdated Show resolved Hide resolved
@scr-oath scr-oath requested a review from bsardo December 11, 2024 23:37
bsardo
bsardo previously approved these changes Dec 12, 2024
View reviewed changes
@bsardo
Copy link
Collaborator

bsardo commented Dec 13, 2024

@scr-oath can you merge with master?

@scr-oath
Copy link
Contributor Author

@scr-oath can you merge with master?

Well it had conflicts by the time I got to it, so I need approvals again… I don't see any merge button at the moment though; do I need to be added to some github group to be able to merge after approval?

@bsardo
Copy link
Collaborator

bsardo commented Dec 13, 2024

@scr-oath can you merge with master?

Well it had conflicts by the time I got to it, so I need approvals again… I don't see any merge button at the moment though; do I need to be added to some github group to be able to merge after approval?

👍 After I approved, I merged a PR that introduced conflicts. We have configured the repo to wipe out approvals anytime a change is made so I was expecting to have to re-review. The core review team has permissions to merge. As discussed at the PBS-Go Dev meeting kickoff earlier this week, once reviewers go through a training program of sort they will have permissions to merge.

@SyntaxNode SyntaxNode merged commit 467f728 into prebid:master Dec 13, 2024
3 checks passed
@cross-repo-issue-creation cross-repo-issue-creation bot mentioned this pull request Dec 13, 2024
Closed
scr-oath added a commit to scr-oath/prebid-server that referenced this pull request Dec 16, 2024
@scr-oath
Older devices are sending "gpc": 1 and this can't marshal. (prebid#4070)
383bcdb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SyntaxNode SyntaxNode SyntaxNode approved these changes

@bsardo bsardo bsardo approved these changes

Assignees

@bsardo bsardo

@SyntaxNode SyntaxNode

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scr-oath @bsardo @SyntaxNode