GumGum: Add product parameter

adapters/gumgum/gumgum.go

@@ -14,13 +14,13 @@ import (
 	"github.com/prebid/prebid-server/v2/openrtb_ext"
 )
 
-// GumGumAdapter implements Bidder interface.
-type GumGumAdapter struct {
+// adapter implements Bidder interface.
+type adapter struct {
 	URI string
 }
 
 // MakeRequests makes the HTTP requests which should be made to fetch bids.
-func (g *GumGumAdapter) MakeRequests(request *openrtb2.BidRequest, reqInfo *adapters.ExtraRequestInfo) ([]*adapters.RequestData, []error) {
+func (g *adapter) MakeRequests(request *openrtb2.BidRequest, reqInfo *adapters.ExtraRequestInfo) ([]*adapters.RequestData, []error) {
 	var validImps []openrtb2.Imp
 	var siteCopy openrtb2.Site
 	if request.Site != nil {
@@ -80,7 +80,7 @@ func (g *GumGumAdapter) MakeRequests(request *openrtb2.BidRequest, reqInfo *adap
 }
 
 // MakeBids unpacks the server's response into Bids.
-func (g *GumGumAdapter) MakeBids(internalRequest *openrtb2.BidRequest, externalRequest *adapters.RequestData, response *adapters.ResponseData) (*adapters.BidderResponse, []error) {
+func (g *adapter) MakeBids(internalRequest *openrtb2.BidRequest, externalRequest *adapters.RequestData, response *adapters.ResponseData) (*adapters.BidderResponse, []error) {
 	if response.StatusCode == http.StatusNoContent {
 		return nil, nil
 	}
@@ -176,6 +176,14 @@ func preprocess(imp *openrtb2.Imp) (*openrtb_ext.ExtImpGumGum, error) {
 		}
 	}
 
+	if gumgumExt.Product != "" {
+		var err error
+		imp.Ext, err = json.Marshal(map[string]string{"product": gumgumExt.Product})
+		if err != nil {
+			return nil, err
+		}
+	}
+
 	return &gumgumExt, nil
 }
 
@@ -223,7 +231,7 @@ func validateVideoParams(video *openrtb2.Video) (err error) {
 
 // Builder builds a new instance of the GumGum adapter for the given bidder with the given config.
 func Builder(bidderName openrtb_ext.BidderName, config config.Adapter, server config.Server) (adapters.Bidder, error) {
-	bidder := &GumGumAdapter{
+	bidder := &adapter{
 		URI: config.Endpoint,
 	}
 	return bidder, nil

adapters/gumgum/params_test.go

@@ -37,11 +37,13 @@ var validParams = []string{
 	`{"zone":"dc9d6be1"}`,
 	`{"pubId":12345678}`,
 	`{"zone":"dc9d6be1", "pubId":12345678}`,
+	`{"zone":"dc9d6be1", "pubId":12345678, "product": "skins"}`,
 	`{"zone":"dc9d6be1", "slot":1234567}`,
 	`{"pubId":12345678, "slot":1234567}`,
 	`{"pubId":12345678, "irisid": "iris_6f9285823a48bne5"}`,
 	`{"zone":"dc9d6be1", "irisid": "iris_6f9285823a48bne5"}`,
 	`{"zone":"dc9d6be1", "pubId":12345678, "irisid": "iris_6f9285823a48bne5"}`,
+	`{"zone":"dc9d6be1", "pubId":12345678, "irisid": "iris_6f9285823a48bne5", "product": "skins"}`,
 }
 
 var invalidParams = []string{
@@ -62,4 +64,6 @@ var invalidParams = []string{
 	`{"zone":"1234567", "irisid": ""}`,
 	`{"zone":"1234567", "irisid": 1234}`,
 	`{"irisid": "iris_6f9285823a48bne5"}`,
+	`{"product": "test"}`,
+	`{"product": 12345678}`,
 }

openrtb_ext/imp_gumgum.go

@@ -3,10 +3,11 @@ package openrtb_ext
 // ExtImpGumGum defines the contract for bidrequest.imp[i].ext.prebid.bidder.gumgum
 // Either Zone or PubId must be present, others are optional parameters
 type ExtImpGumGum struct {
-	Zone   string  `json:"zone,omitempty"`
-	PubID  float64 `json:"pubId,omitempty"`
-	IrisID string  `json:"irisid,omitempty"`
-	Slot   float64 `json:"slot,omitempty"`
+	Zone    string  `json:"zone,omitempty"`
+	PubID   float64 `json:"pubId,omitempty"`
+	IrisID  string  `json:"irisid,omitempty"`
+	Slot    float64 `json:"slot,omitempty"`
+	Product string  `json:"product,omitempty"`
 }
 
 // ExtImpGumGumVideo defines the contract for bidresponse.seatbid.bid[i].ext.prebid.bidder.gumgum.video

static/bidder-params/gumgum.json

@@ -20,6 +20,10 @@
     "slot": {
       "type": "integer",
       "description": "A slot id used to identify a slot placement mapped to a GumGum zone or publisher"
+    }, 
+    "product": {
+      "type": "string",
+      "description": "Product param that allow support for Desktop Skins - display and video"
     }
   },
   "anyOf": [
@@ -34,4 +38,4 @@
       ]
     }
   ]
-}
+}