Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GumGum: Add product parameter #3253

Merged
merged 5 commits into from
Nov 16, 2023
Merged

GumGum: Add product parameter #3253

merged 5 commits into from
Nov 16, 2023

Conversation

gg-natalia
Copy link
Contributor

In these changes, we are starting to pass the product param from Prebid Server to GG Ad Server under the impressions.ext param.
For any questions/comments pls feel free to reach out.
Thanks
Natalia Castiglioni

github-actions[bot]
github-actions bot reviewed Oct 24, 2023
View reviewed changes
adapters/gumgum/gumgum.go Outdated Show resolved Hide resolved
@gg-natalia gg-natalia force-pushed the ADTS-396-add-gg-product-param branch 2 times, most recently from 380b3aa to 52f0b1e Compare October 24, 2023 15:31
@gg-natalia gg-natalia force-pushed the ADTS-396-add-gg-product-param branch from 52f0b1e to 2d088c2 Compare October 24, 2023 15:34
@github-actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 2d088c2

gumgum

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:23:	MakeRequests		93.5%
github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:83:	MakeBids		78.9%
github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:127:	preprocess		79.4%
github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:186:	getBiggerFormat		100.0%
github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:210:	getMediaTypeForImpID	100.0%
github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:219:	validateVideoParams	100.0%
github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:229:	Builder			100.0%
total:									(statements)		87.9%

@SyntaxNode SyntaxNode changed the title Add product support for gg gumgum: Add product parameter Oct 24, 2023
@github-actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, aacc879

gumgum

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:23:	MakeRequests		93.5%
github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:83:	MakeBids		78.9%
github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:127:	preprocess		73.0%
github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:191:	getBiggerFormat		100.0%
github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:215:	getMediaTypeForImpID	100.0%
github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:224:	validateVideoParams	100.0%
github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:234:	Builder			100.0%
total:									(statements)		85.5%

@github-actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 71d44ba

gumgum

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:23:	MakeRequests		93.5%
github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:83:	MakeBids		78.9%
github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:127:	preprocess		73.0%
github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:190:	getBiggerFormat		100.0%
github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:214:	getMediaTypeForImpID	100.0%
github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:223:	validateVideoParams	100.0%
github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:233:	Builder			100.0%
total:									(statements)		85.5%

@github-actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, f030cb6

gumgum

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:23:	MakeRequests		93.5%
github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:83:	MakeBids		78.9%
github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:127:	preprocess		73.0%
github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:190:	getBiggerFormat		100.0%
github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:214:	getMediaTypeForImpID	100.0%
github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:223:	validateVideoParams	100.0%
github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:233:	Builder			100.0%
total:									(statements)		85.5%

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, cb64523

gumgum

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:23:	MakeRequests		93.5%
github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:83:	MakeBids		78.9%
github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:127:	preprocess		73.0%
github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:190:	getBiggerFormat		100.0%
github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:214:	getMediaTypeForImpID	100.0%
github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:223:	validateVideoParams	100.0%
github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:233:	Builder			100.0%
total:									(statements)		85.5%

@gg-natalia
Copy link
Contributor Author

@onkarvhanumante @Sonali-More-Xandr Hey, do you know if anything is pending on my side ? Thanks!!!

@gg-natalia
Copy link
Contributor Author

Hey, any idea on when this going to be merged ? Thanks!

@bsardo bsardo changed the title gumgum: Add product parameter GumGum: Add product parameter Nov 16, 2023
@bsardo bsardo merged commit 9693797 into prebid:master Nov 16, 2023
5 checks passed
@cross-repo-issue-creation cross-repo-issue-creation bot mentioned this pull request Nov 16, 2023
Closed
svamiftah pushed a commit to sovrn/prebid-server that referenced this pull request Nov 21, 2023
@gg-natalia @svamiftah
GumGum: Add product parameter (prebid#3253)
6f5a407
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@SyntaxNode SyntaxNode SyntaxNode left review comments

@Sonali-More-Xandr Sonali-More-Xandr Sonali-More-Xandr approved these changes

@onkarvhanumante onkarvhanumante onkarvhanumante approved these changes

Assignees

@onkarvhanumante onkarvhanumante

@Sonali-More-Xandr Sonali-More-Xandr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gg-natalia @SyntaxNode @onkarvhanumante @Sonali-More-Xandr @bsardo