-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable entrypoint checkbox in Project Files view #2487
Conversation
f9a03ca
to
c6c7552
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks great. I'll test shortly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code functions well. I tested it with multiple existing configurations.
I do wonder if the entrypoint file should be visually indicated a little more than the slight opacity change which you implemented. Perhaps with another visual icon, asterick, something?
I do think, regardless of the visual note above, that you should go ahead and add to the tooltip that the entrypoint cannot be removed from the deployment file list.
The entrypoint file should be emphasized with the color, and the opacity change is to avoid the disabled state making it semi-transparent (and less emphasized). We don't have any other icons or anything in that Project Files view so I'm not quite sure what exactly to do to further visually emphasize it. 🤔
Great point. I'll get that in real quick ⌨️ 🏃 |
c6c7552
to
23230eb
Compare
Got the tooltip change in 😄 |
45632a9
to
39ad424
Compare
39ad424
to
976e62b
Compare
Thanks for making the changes. @marcosnav I haven't verified the functionality after Jordan made the last changes. Can you test and merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This prevents the user from unchecking the entrypoint checkbox (and therefor removing the entrypoint from the
files
attribute in their configuration).The configuration can still be edited by hand, but the sidebar no longer allows getting into this bad state.
Intent
Part of #1493
Type of Change
User Impact
The user will no longer be able to uncheck the entrypoint's checkbox.
Directions for Reviewers
Ensure that the entrypoint, no matter the details in the configuration, can be unchecked.
Checking the entrypoint checkbox should still be available if the configuration is manually edited and the entrypoint needs to be added.