Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow entrypoint file to be excluded from Project #1493

Open
1 of 4 tasks
kgartland-rstudio opened this issue May 1, 2024 · 3 comments
Open
1 of 4 tasks

Don't allow entrypoint file to be excluded from Project #1493

kgartland-rstudio opened this issue May 1, 2024 · 3 comments
Labels
Milestone

Comments

@kgartland-rstudio
Copy link
Collaborator

kgartland-rstudio commented May 1, 2024

You can exclude the entrypoint file from the Configuration File in the UI under Project Files. Since the entrypoint is required, can we block that from being excluded?

I know we can't stop them from manually editing the Configuration File but it seems like we can guard against them breaking themselves from doing it in the extension.


  • Add a pre-flight check to ensure the entrypoint is included
  • Add a warning in the sidebar when the entrypoint is not included in the selected configuration
  • Disallow the Files API from removing the entrypoint
  • Disable the checkbox in the Project Files view (handled in Disable entrypoint checkbox in Project Files view #2487)
@kgartland-rstudio kgartland-rstudio added enhancement New feature or request vscode labels May 1, 2024
@mmarchetti
Copy link
Contributor

Also see #1503

@mmarchetti
Copy link
Contributor

Files API should return a "reason" for these named files that mandates their inclusion.

@mmarchetti
Copy link
Contributor

Also should have a preflight check for this.

@dotNomad dotNomad modified the milestones: v1.2.0, v1.1.7 Sep 20, 2024
@m-- m-- added this to the v.1.8.0 milestone Dec 10, 2024
@dotNomad dotNomad self-assigned this Dec 12, 2024
@dotNomad dotNomad removed their assignment Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants