Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Fix duplicate cols in new-streaming parquet prefilter #20419

Merged
merged 1 commit into from
Dec 23, 2024
+7 −1
Merged

refactor(rust): Fix duplicate cols in new-streaming parquet prefilter #20419

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion crates/polars-stream/src/nodes/io_sources/parquet/init.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,12 +272,14 @@ impl ParquetSourceNode {
.collect_live_columns(&mut live_columns);
let v = (!live_columns.is_empty())
.then(|| {
let out = live_columns
let mut out = live_columns
.iter()
// Can be `None` - if the column is e.g. a hive column, or the row index column.
.filter_map(|x| projected_arrow_schema.index_of(x))
.collect::<Vec<_>>();

out.sort_unstable();

// There is at least one non-predicate column, or pre-filtering was
// explicitly requested (only useful for testing).
(out.len() < projected_arrow_schema.len()
Expand Down Expand Up @@ -363,6 +365,10 @@ impl ParquetSourceNode {
/// Returns 0..len in a Vec, excluding indices in `exclude`.
/// `exclude` needs to be a sorted list of unique values.
fn filtered_range(exclude: &[usize], len: usize) -> Vec<usize> {
if cfg!(debug_assertions) {
assert!(exclude.windows(2).all(|x| x[1] > x[0]));
}

let mut j = 0;

(0..len)
Expand Down
Loading