Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Fix duplicate cols in new-streaming parquet prefilter #20419

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Dec 23, 2024

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Dec 23, 2024
@nameexhaustion nameexhaustion changed the title refactor(rust): Fix new-streaming parquet prefiltered refactor(rust): Fix duplicate cols in new-streaming parquet prefilter Dec 23, 2024
@nameexhaustion nameexhaustion marked this pull request as ready for review December 23, 2024 13:21
@coastalwhite
Copy link
Collaborator

This is my bad. I saw that we now had a Set, so the dedup could be removed. I wrongly assumed the sort_unstable was for the dedup.

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 78.98%. Comparing base (6aaa98c) to head (33cfa69).
Report is 39 commits behind head on main.

Files with missing lines Patch % Lines
...polars-stream/src/nodes/io_sources/parquet/init.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20419      +/-   ##
==========================================
- Coverage   78.99%   78.98%   -0.01%     
==========================================
  Files        1562     1562              
  Lines      220104   220108       +4     
  Branches     2486     2486              
==========================================
- Hits       173865   173852      -13     
- Misses      45666    45683      +17     
  Partials      573      573              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion
Copy link
Collaborator Author

I wrongly assumed the sort_unstable was for the dedup.

Ah - that makes sense actually, I think I would have done the same 😄

@ritchie46 ritchie46 merged commit f5d8903 into pola-rs:main Dec 23, 2024
24 checks passed
@c-peters c-peters added the accepted Ready for implementation label Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants