Reuse existing output #1180
Reuse existing output #1180
Conversation
|
🚀 Regression report for commit eec67a0 is at https://web-php-regression-report-pr-1180.preview.thephp.foundation |
|
🚀 Preview for commit eec67a0 can be found at https://web-php-pr-1180.preview.thephp.foundation |
manual/en/function.strpos.php
Outdated
| @@ -197,4 +197,4 @@ function.</p></div> | |||
| </div> | |||
|
|
|||
|
|
|||
| </div><?php manual_footer(); ?> | |||
| </div><?php manual_footer([]); ?> | |||
There was a problem hiding this comment.
did you meant to commit the manual files?
There was a problem hiding this comment.
Yes, because this is needed to be able to test with a local dev setup. Have split it into a different commit so it can easily be merged separately.
But happy to commit this outside of the PR.
js/interactive-examples.js
Outdated
| lastOutput = createOutput(PHP.buffer.join("")); | ||
| phpcode.parentNode.appendChild(lastOutput); | ||
| if (exampleScreenPreElement !== null) { | ||
| exampleTitleParagraphElement.innerText = "Output of the above example in PHP "+ PHP.version +":"; |
There was a problem hiding this comment.
could you maybe store this string in a variable as its used twice?
manual/en/function.strpos.php
Outdated
| array ( | ||
| 0 => 'function.strpbrk.php', | ||
| 1 => 'strpbrk', | ||
| 0 => 'ref.strings.php', | ||
| 1 => 'String Functions', | ||
| ), | ||
| 'next' => | ||
| array ( | ||
| 0 => 'function.strrchr.php', | ||
| 1 => 'strrchr', | ||
| 0 => 'function.rtrim.php', | ||
| 1 => 'rtrim', |
There was a problem hiding this comment.
There's a problem with indentation here.
|
@soyuka Whenever I click
|
Girgias
force-pushed
the
reuse-existing-output
branch
from
03078e4 to
46b1e1f
Compare
|
@sy-records which page are you encountering this? As I don't have this issue from a quick glance. |
|
Still nothing on Firefox, even when using the ZH language on the live manual :/ |
|
I can reproduce it in both Chrome and Firefox.
|
@soyuka my JS skills are very rusty, so there might be a better and less tag dependent way on doing this.
But this allows reusing the existing output for examples if it exists.