Hooks reflection #4110
Hooks reflection #4110
Conversation
Co-authored-by: Gina Peter Banyard <[email protected]>
Crell
force-pushed
the
hooks-reflection
branch
from
b2540ee to
dcdd281
Compare
| $rProp->getHook(PropertyHookType::Get); // Returns an instance of \ReflectionMethod. | ||
| $rProp->getHook(PropertyHookType::Set); // Returns null. |
There was a problem hiding this comment.
I would prefer a var_dump() (possible using ::class) with a screen tag instead of a comment, as those are more annoying for translations.
There was a problem hiding this comment.
Hm. In that case, do we even need the screen tag anymore? Just have it show output and leave it to the new wasm runner.
There was a problem hiding this comment.
Yes, I have php/web-php#1180 to reuse the output.
I don't see the point in forcing everyone to run WASM, and require JS, just to see the expected output.
|
I didn't realize, but @Crell you didn't address some of the review comments. |
|
Switched all the examples to generate output. I did not include the output, because it's a hassle to do and we now have the Wasm runner that will produce it for us on-demand. |
Crell
force-pushed
the
hooks-reflection
branch
from
d7c5dd1 to
a204b11
Compare
|
@Girgias Which comments haven't been addressed? |
|
I disagree that manually pre-generating the output is worthwhile now that we have the Wasm runner. If someone else would like to modify the PR to include that, go ahead, but I have limited time with a baby now, so won't be doing so. |
New PR, includes #4039, which generates the stubs.
Resolves #4039.
I'm not certain if the enum is in the right place, but I wasn't sure where else to put it. Open to suggestions.