Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSSDK-9950] chore: SPM support added to bundle privacy manifest file #544

Merged
merged 2 commits into from
Jan 18, 2024
Merged

[FSSDK-9950] chore: SPM support added to bundle privacy manifest file #544

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c65ebf
SPM support added for privacy manifes file
muzahidul-opti Jan 18, 2024
5ea5a99
Compiled language version added
muzahidul-opti Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
// swift-tools-version:5.0
// swift-tools-version:5.3
// The Swift tools version declares the version of the PackageDescription library,
// the minimum version of the Swift tools and Swift language compatibility version to process the manifest,
// and the minimum version of the Swift tools that are needed to use the Swift package.

import PackageDescription

let package = Package(
Expand All @@ -14,7 +18,11 @@ let package = Package(
targets: ["Optimizely"])
],
targets: [
.target(name: "Optimizely", path: "Sources")
.target(
name: "Optimizely",
path: "Sources",
resources: [.copy("Supporting Files/PrivacyInfo.xcprivacy")]
)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to exclude the file and add it in the resource. I couldn't find documentation saying it but I checked many libraries that are doing that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to exclude the file and add it in the resource. I couldn't find documentation saying it but I checked many libraries that are doing that.

I also haven't found any proper documentation so far. But I think exclude and added as resource same file is a kind of self-contradictory to me. I also checked it works well and didn't throw any warning or error.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the reasoning is to not add it in the source code but only inside the resource bundle. But if both works then choose whatever makes more sense for you.

],
swiftLanguageVersions: [.v5]
swiftLanguageVersions: [.v5, .version("5.9")]
)
Loading