Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSSDK-9950] chore: SPM support added to bundle privacy manifest file #544

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

muzahidul-opti
Copy link
Contributor

Summary

Issues

@muzahidul-opti muzahidul-opti marked this pull request as ready for review January 18, 2024 12:37
@muzahidul-opti muzahidul-opti requested a review from a team as a code owner January 18, 2024 12:37
@muzahidul-opti muzahidul-opti requested a review from jaeopt January 18, 2024 12:37
.target(
name: "Optimizely",
path: "Sources",
resources: [.copy("Supporting Files/PrivacyInfo.xcprivacy")]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to exclude the file and add it in the resource. I couldn't find documentation saying it but I checked many libraries that are doing that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to exclude the file and add it in the resource. I couldn't find documentation saying it but I checked many libraries that are doing that.

I also haven't found any proper documentation so far. But I think exclude and added as resource same file is a kind of self-contradictory to me. I also checked it works well and didn't throw any warning or error.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the reasoning is to not add it in the source code but only inside the resource bundle. But if both works then choose whatever makes more sense for you.

Copy link
Collaborator

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muzahidul-opti muzahidul-opti merged commit 988338e into master Jan 18, 2024
10 of 12 checks passed
@muzahidul-opti muzahidul-opti deleted the muzahid/spm-support-privacy-manifest branch January 18, 2024 17:03
muzahidul-opti added a commit that referenced this pull request Jan 18, 2024
* SPM support added for privacy manifes file

* Compiled language version added
@muzahidul-opti muzahidul-opti changed the title [FSSDK-9950] chore: SPM support added to process privacy manifest [FSSDK-9950] chore: SPM support added to bundle privacy manifest file Jan 19, 2024
muzahidul-opti added a commit that referenced this pull request Jan 19, 2024
* Privacy access api types value updated (#541)

* Add coccoapods support for privacy manifest (#542)

* [FSSDK-9950] chore: SPM support added to process privacy manifest (#544)

* SPM support added for privacy manifes file

* Compiled language version added

* Update CHANGELOG.md

* Update README.md

* Update swift.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants