-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FSSDK-9950] chore: SPM support added to bundle privacy manifest file #544
Conversation
.target( | ||
name: "Optimizely", | ||
path: "Sources", | ||
resources: [.copy("Supporting Files/PrivacyInfo.xcprivacy")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to exclude the file and add it in the resource. I couldn't find documentation saying it but I checked many libraries that are doing that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to exclude the file and add it in the resource. I couldn't find documentation saying it but I checked many libraries that are doing that.
I also haven't found any proper documentation so far. But I think exclude and added as resource same file is a kind of self-contradictory to me. I also checked it works well and didn't throw any warning or error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the reasoning is to not add it in the source code but only inside the resource bundle. But if both works then choose whatever makes more sense for you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* SPM support added for privacy manifes file * Compiled language version added
* Privacy access api types value updated (#541) * Add coccoapods support for privacy manifest (#542) * [FSSDK-9950] chore: SPM support added to process privacy manifest (#544) * SPM support added for privacy manifes file * Compiled language version added * Update CHANGELOG.md * Update README.md * Update swift.yml
Summary
Issues