-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to Brave 5.18 with zipkin-reporter 3 #98
Conversation
2e616fb
to
aa4112d
Compare
I think the failures are explainable and will go away in Brave 6, but @anuraaga @reta or @shakuzen if you can check my sanity. What this does is remove the zipkin dependency from zipkin-reporter, but brave still references zipkin core types. I think Spring autoconfig scans the whole file then would find those, and so the zipkin jar is needed for Spring autoconfig until Brave 6. Ratpack, cassandra and dropwizard fail because they use third-party tracing which is not yet updated to avoid zipkin core types. Similar with sleuth (zipkin2.reporter.BytesMessageEncoder depends internally on zipkin types). These projects should claim their own dependency on zipkin-reporter (not incidentally through zipkin-reporter-brave) until they don't use those types. We can probably do that here and raise a PR on each accordingly. One reason to use zipkin-reporter is a project that uses formats besides json. TL;DR; is I think zipkin-reporter 3 is good, as if it wasn't the other 5 tests wouldn't pass, so we can ship that an move forward to Brave (release 5.18 with reporter 3, but brave still has a zipkin dep for deprecateed methods.. then immediately Brave 6 to remove them) |
I think it makes sense @codefromthecrypt , the 3.x is next major and it is fine to require some work for other projects to migrate (like those deps on zipkin you've mentioned). |
dropwizard-zipkin will be removed as the tracing repo was archived: #99 |
Signed-off-by: Adrian Cole <[email protected]>
7a44e60
to
f7ec59e
Compare
removed ratpack as it was abandoned |
<cassandra.version>3.11.9</cassandra.version> | ||
<!-- Use the cassandra-driver-core version bundled in cassandra to not conflict with Netty. --> | ||
<cassandra-driver-core.version>3.0.1</cassandra-driver-core.version> | ||
<cassandra.version>4.1.3</cassandra.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was at it, so updated cassandra
Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
@@ -21,6 +21,7 @@ | |||
|
|||
<spring-boot.version>2.3.7.RELEASE</spring-boot.version> | |||
<sleuth.version>2.2.6.RELEASE</sleuth.version> | |||
<zipkin-reporter.version>${old-zipkin-reporter.version}</zipkin-reporter.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sleuth uses an old version of zipkin-reporter and as it is unmaintained, probably won't update. Brave 6 removes version management from reporter for reasons like this.
No description provided.