Skip to content

Commit

Permalink
Updates to Brave 5.18 with zipkin-reporter 3
Browse files Browse the repository at this point in the history
Signed-off-by: Adrian Cole <[email protected]>
  • Loading branch information
Adrian Cole committed Jan 7, 2024
1 parent 6328492 commit aa4112d
Show file tree
Hide file tree
Showing 3 changed files with 38 additions and 5 deletions.
4 changes: 2 additions & 2 deletions build-bin/docker-compose-kafka.test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ version: "2.4"
services:
sut:
container_name: sut
image: ghcr.io/openzipkin/alpine:3.18.5
image: ghcr.io/openzipkin/alpine:3.19.0
entrypoint: /bin/sh
# Keep the container running until HEALTHCHECK passes
command: "-c \"sleep 5m\""
Expand All @@ -18,7 +18,7 @@ services:

get_frontend:
container_name: get_frontend
image: ghcr.io/openzipkin/alpine:3.18.5
image: ghcr.io/openzipkin/alpine:3.19.0
entrypoint: /bin/sh
# Pass a trace header with a constant trace ID, so that we know what to look for later
command: "-c \"wget -qO- --header 'b3: cafebabecafebabe-cafebabecafebabe-1' http://frontend:8081\""
Expand Down
4 changes: 2 additions & 2 deletions build-bin/docker-compose.test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ version: "2.4"
services:
sut:
container_name: sut
image: ghcr.io/openzipkin/alpine:3.18.5
image: ghcr.io/openzipkin/alpine:3.19.0
entrypoint: /bin/sh
# Keep the container running until HEALTHCHECK passes
command: "-c \"sleep 5m\""
Expand All @@ -16,7 +16,7 @@ services:
condition: service_started
get_frontend:
container_name: get_frontend
image: ghcr.io/openzipkin/alpine:3.18.5
image: ghcr.io/openzipkin/alpine:3.19.0
entrypoint: /bin/sh
# Pass a trace header with a constant trace ID, so that we know what to look for later
command: "-c \"wget -qO- --header 'b3: cafebabecafebabe-cafebabecafebabe-1' http://frontend:8081\""
Expand Down
35 changes: 34 additions & 1 deletion parent-pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,28 @@
</license>
</licenses>

<repositories>
<repository>
<id>sonatype.snapshots</id>
<name>Sonatype Snapshots</name>
<url>https://oss.sonatype.org/content/repositories/snapshots/</url>
<releases>
<enabled>false</enabled>
</releases>
<snapshots>
<enabled>true</enabled>
</snapshots>
</repository>
</repositories>

<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.build.resourceEncoding>UTF-8</project.build.resourceEncoding>
<project.build.outputEncoding>UTF-8</project.build.outputEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>

<brave.version>5.17.1</brave.version>
<brave.version>5.18.0-SNAPSHOT</brave.version>
<zipkin-reporter.version>3.0.0-SNAPSHOT</zipkin-reporter.version>

<!-- The JRE used in Docker images can be higher than ${maven.compiler.release}. -->
<jre.version>SET MANUALLY IN PROJECTS</jre.version>
Expand All @@ -53,13 +68,31 @@
<!-- Only declare Brave dependencies here as we want projects to control their own settings -->
<dependencyManagement>
<dependencies>
<dependency>
<groupId>io.zipkin.reporter2</groupId>
<artifactId>zipkin-reporter-bom</artifactId>
<version>${zipkin-reporter.version}</version>
<type>pom</type>
<scope>import</scope>
</dependency>
<dependency>
<groupId>io.zipkin.brave</groupId>
<artifactId>brave-bom</artifactId>
<version>${brave.version}</version>
<type>pom</type>
<scope>import</scope>
</dependency>
<dependency>
<groupId>io.zipkin.brave</groupId>
<artifactId>brave</artifactId>
<version>${brave.version}</version>
<exclusions>
<exclusion>
<groupId>*</groupId>
<artifactId>*</artifactId>
</exclusion>
</exclusions>
</dependency>
</dependencies>
</dependencyManagement>

Expand Down

0 comments on commit aa4112d

Please sign in to comment.