-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chart/data-prepper): Add configurable global.dockerRegistry #631
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,6 +7,10 @@ | |
|
||
replicaCount: 1 | ||
|
||
global: | ||
# Set if you want to change the default docker registry, e.g. a private one. | ||
dockerRegistry: "" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Minor: I'd prefer There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Following other charts part of the repo (https://github.com/opensearch-project/helm-charts/blob/main/charts/opensearch/values.yaml#L29) we can go with |
||
|
||
image: | ||
# -- The image repository from which to pull the Data Prepper image | ||
repository: opensearchproject/data-prepper | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this missing part
[0.1.0]
.