feat(chart/data-prepper): Add configurable global.dockerRegistry #631
+23
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Høydahl <[email protected]>
janhoy
requested review from
TheAlgo,
DandyDeveloper,
peterzhuamazon,
prudhvigodithi and
gaiksaya
as code owners
janhoy
commented
Dec 17, 2024
| @@ -7,6 +7,10 @@ | |||
|
|
|||
| replicaCount: 1 | |||
|
|
|||
| global: | |||
| # Set if you want to change the default docker registry, e.g. a private one. | |||
| dockerRegistry: "" | |||
There was a problem hiding this comment.
Minor: I'd prefer imageRegistry, but I believe it's more important to align with existing opensearch charts for now. Then a rename could be done across the board later.
There was a problem hiding this comment.
Following other charts part of the repo (https://github.com/opensearch-project/helm-charts/blob/main/charts/opensearch/values.yaml#L29) we can go with dockerRegistry.
|
Thanks @janhoy LGTM, adding @SergK |
prudhvigodithi
approved these changes
Dec 23, 2024
| ### Added | ||
| - Added configurable `global.dockerRegistry` | ||
|
|
||
| ## [0.1.0] |
There was a problem hiding this comment.
Thanks for adding this missing part [0.1.0].
prudhvigodithi
approved these changes
Dec 23, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes docker registry configurable separate from docker repository for easier configuration of custom registries.
Issues Resolved
Fixes #630
Check List
For any changes to files within Helm chart directories:
CHANGELOG.mdupdated to reflect changeBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.