Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for visual issues with Resources vertical tabs and Spawner page image selectors #3596

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −4
Open

Fixes for visual issues with Resources vertical tabs and Spawner page image selectors #3596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions frontend/src/app/App.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,13 @@ body,
--pf-v6-c-truncate__start--MinWidth: 0;
}

// TODO: Remove when PF bug is fixed. https://github.com/patternfly/react-catalog-view/issues/74
.vertical-tabs-pf-tab {
> a {
text-decoration: none;
}
}

// TODO: Remove when PF bug is fixed. https://github.com/patternfly/patternfly-react/issues/11314
.pf-v6-c-table__text.pf-m-truncate {
min-width: max(100%, 5ch);
Expand Down
1 change: 1 addition & 0 deletions frontend/src/pages/learningCenter/CategoryFilters.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ const CategoryFilters: React.FC<CategoryFiltersProps> = ({ docApps, favorites })
active={category === categoryQuery || (!categoryQuery && category === ALL_ITEMS)}
onActivate={() => onSelectCategory(category)}
tabIndex={-1}
style={{ textDecoration: 'none' }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this redundant to the css change?

/>
))}
</VerticalTabs>
Expand Down
3 changes: 0 additions & 3 deletions frontend/src/pages/notebookController/NotebookController.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,6 @@
&-package-title {
font-weight: var(--pf-t--global--font--weight--heading--bold);
}
&-icon {
padding-left: 0px;
}
}
}
&__start-server-modal {
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/pages/notebookController/screens/server/ImageTagPopover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ const ImageTagPopover: React.FC<ImageTagPopoverProps> = ({ tag, description }) =
>
<Button
icon={<HelpIcon />}
hasNoPadding
aria-label="More info for notebook image"
className="odh-notebook-controller__notebook-image-popover-icon"
variant="plain"
/>
</Popover>
Expand Down
Loading