Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for visual issues with Resources vertical tabs and Spawner page image selectors #3596

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jeff-phillips-18
Copy link
Contributor

Closes RHOAIENG-16677

Description

Removes underlines from text in resource category filter options.
Fixes alignment of radio buttons in the Spawner page

How Has This Been Tested?

  • Navigate to Resources page

  • Verify the category links are not underlined

  • Navigate to Data Science Projects

  • Select a project

  • Select the Workbenches tab

  • Select Create workbench

  • Verify the alignment of the image selector radio buttons

Test Impact

Not impact on tests as this is purely visual

Screen shots

image

image

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)
  • Included any necessary screenshots or gifs if it was a UI change.

Copy link
Contributor

openshift-ci bot commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign manosnoam for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.15%. Comparing base (14b1c4d) to head (34140ba).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3596      +/-   ##
==========================================
- Coverage   85.16%   85.15%   -0.01%     
==========================================
  Files        1393     1393              
  Lines       31939    31939              
  Branches     8955     8955              
==========================================
- Hits        27200    27199       -1     
- Misses       4739     4740       +1     
Files with missing lines Coverage Δ
...ntend/src/pages/learningCenter/CategoryFilters.tsx 93.54% <ø> (ø)
...ebookController/screens/server/ImageTagPopover.tsx 83.33% <ø> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14b1c4d...34140ba. Read the comment docs.

@@ -59,6 +59,7 @@ const CategoryFilters: React.FC<CategoryFiltersProps> = ({ docApps, favorites })
active={category === categoryQuery || (!categoryQuery && category === ALL_ITEMS)}
onActivate={() => onSelectCategory(category)}
tabIndex={-1}
style={{ textDecoration: 'none' }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this redundant to the css change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants