Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spindle-tokens): fix x icon color #102

Merged
merged 2 commits into from
Jun 18, 2024
Merged

feat(spindle-tokens): fix x icon color #102

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a48ec1c
chore: deprecated --x-blue due to undefined color value
tatz012 Jun 14, 2024
ef2ca41
feat: added --color-third-party-x-black
tatz012 Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ameba-color-palette.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,8 @@
--color-third-party-facebook-white: var(--facebook-white);
--color-third-party-twitter-blue: var(--twitter-blue);
--color-third-party-twitter-white: var(--twitter-white);
--color-third-party-x-blue: var(--x-blue);
--color-third-party-x-blue: var(--x-blue); /* deprecated. --x-blue- is undefined. specifying it won't change the color. */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/** @deprecated */ をつけたらIntelliJやVSCodeがインポート先のCSSでこの変数を使った時に非推奨だよ〜的な表示をしてくれるのでは、的なことを @tatz-ibz と話したんですが特にそういうことにはならないそうです。

Copy link
Contributor

@itsminadesu itsminadesu Jun 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@herablog @tokimari @yasuda-shin
過去にdeprecatedパターンに遭遇したことがないのですが、上記のような実装（コメント）で問題ないですよね...？（一応確認させていただきたいです 🙏🏻 ）

Copy link
Member

@herablog herablog Jun 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

何かしらインポート先で示唆できるとベストではありますが、今回の対応ではこれで全然大丈夫です！(色も当たらないですし)

Copy link
Contributor

@tokimari tokimari Jun 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

過去にdeprecatedにした色はありましたが、その時は特にコメントは残さずRelease Noteに記載していましたね。
https://github.com/openameba/ameba-color-palette.css/releases/tag/v2.0.0

リリースノート見に行くより定義見る方が楽なので、コメントにある分には（動作に支障がなければ）良いのではないでしょうか 👀

--color-third-party-x-black: var(--x-black);
--color-third-party-x-white: var(--x-white);
--color-third-party-instagram-pink: var(--instagram-pink);
--color-third-party-apple-black: var(--apple-black);
Expand Down