feat(spindle-tokens): fix x icon color #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatz012
changed the title
sasaplus1
reviewed
Jun 18, 2024
| @@ -194,7 +194,8 @@ | |||
| --color-third-party-facebook-white: var(--facebook-white); | |||
| --color-third-party-twitter-blue: var(--twitter-blue); | |||
| --color-third-party-twitter-white: var(--twitter-white); | |||
| --color-third-party-x-blue: var(--x-blue); | |||
| --color-third-party-x-blue: var(--x-blue); /* deprecated. --x-blue- is undefined. specifying it won't change the color. */ | |||
There was a problem hiding this comment.
/** @deprecated */ をつけたらIntelliJやVSCodeがインポート先のCSSでこの変数を使った時に非推奨だよ〜的な表示をしてくれるのでは、的なことを @tatz-ibz と話したんですが特にそういうことにはならないそうです。
There was a problem hiding this comment.
@herablog @tokimari @yasuda-shin
過去にdeprecatedパターンに遭遇したことがないのですが、上記のような実装（コメント）で問題ないですよね...？（一応確認させていただきたいです 🙏🏻 ）
There was a problem hiding this comment.
何かしらインポート先で示唆できるとベストではありますが、今回の対応ではこれで全然大丈夫です！(色も当たらないですし)
There was a problem hiding this comment.
過去にdeprecatedにした色はありましたが、その時は特にコメントは残さずRelease Noteに記載していましたね。
https://github.com/openameba/ameba-color-palette.css/releases/tag/v2.0.0
リリースノート見に行くより定義見る方が楽なので、コメントにある分には（動作に支障がなければ）良いのではないでしょうか 👀
itsminadesu
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
Xアイコンの色指定が間違っていたため
--color-third-party-x-blueを指定しても色が適用されない状態になっていました。正しい変数を追加しつつ、コメントでdeprecatedを記載しました。
追加した変数名は openameba/spindle#965 のdesign tokenに合わせて修正しています。