Amendment to PR 53 #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
perlpunk
commented
May 17, 2024
tests/test_comments.py
Outdated
| { | ||
| "issue": { | ||
| "priority_id": 3, | ||
| "notes": "This ticket was set to **Normal** priority but was not updated [within the SLO period](https://example.com/issues). Please consider picking up this ticket or just set the ticket to the next lower priority. The ticket will be set to the next lower priority **Low**." |
There was a problem hiding this comment.
@b10n1k Also, I think the middle sentence is redundant
There was a problem hiding this comment.
I pushed a commit for this.
b10n1k
reviewed
May 17, 2024
| { | ||
| "issue": { | ||
| "priority_id": 3, | ||
| "notes": "This ticket was set to **Normal** priority but was not updated [within the SLO period](https://example.com/issues). The ticket will be set to the next lower priority **Low**." |
There was a problem hiding this comment.
I guess it is fine to have static priorities for that case.
b10n1k
approved these changes
May 17, 2024
Martchus
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried out checking out a PR like this:
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
but now I can't find out how to push changes to this branch.
So I had to create a new PR.