-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix message format on the second reminder #53
Conversation
https://progress.opensuse.org/issues/119176 Signed-off-by: ybonatakis <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test please
In [4]: " ".join([t1, t2]) |
automated unit test in https://github.com/openSUSE/backlogger/tree/main/tests please |
@@ -111,8 +111,8 @@ def _update_issue_priority(poo_id, priority_current, poo_reminder_state, msg): | |||
slo_priorities[priority_current]["next_priority"]["name"], | |||
poo_id)) | |||
url = "{}/{}.json".format(data["web"], poo_id) | |||
msg = " ".join(update_slo_text.format( | |||
priority=slo_priorities[priority_current]["next_priority"]["name"])) | |||
msg = " ".join([reminder_text, update_slo_text.format( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please ensure that unit tests cover this.
https://progress.opensuse.org/issues/159906#note-3 is an example of the problem you want to fix |
I am gonna wait for #54 |
https://progress.opensuse.org/issues/119176