Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply max penalty for sub-segment match #1223

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

t-cordonnier
Copy link
Contributor

During a subsegment search, if some of the subsegments have a penalty, the global segment receives as penalty the highest value

Pull request type

  • Bug fix -> [bug]
  • Feature enhancement -> [enhancement]

Which ticket is resolved?

https://sourceforge.net/p/omegat/bugs/1251/

@miurahr
Copy link
Member

miurahr commented Dec 18, 2024

Why don't you use the maxPanelty variable to process the entry, but use 0?

processEntry(null, entry, "", NearString.MATCH_SOURCE.TM, false, 0);

@t-cordonnier
Copy link
Contributor Author

Why don't you use the maxPanelty variable to process the entry, but use 0?

processEntry(null, entry, "", NearString.MATCH_SOURCE.TM, false, 0);

You are true, I had modified this line in the other PR only, I forgot to do this change when I splitted in two pull requests. I will correct it

@t-cordonnier
Copy link
Contributor Author

Why don't you use the maxPanelty variable to process the entry, but use 0?

processEntry(null, entry, "", NearString.MATCH_SOURCE.TM, false, 0);

You are true, I had modified this line in the other PR only, I forgot to do this change when I splitted in two pull requests.

Corrected now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants