[BUGS#1251][6.0][backport] fix: FindMatches#search ignore penalty when segmented matches #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Backport test case of FindMatchesTest Signed-off-by: Hiroshi Miura <[email protected]>
Minimum backport of PR#963 Signed-off-by: Hiroshi Miura <[email protected]>
Signed-off-by: Hiroshi Miura <[email protected]>
- Add BUGS#1248 which is as same bug as BUGS#1251 Signed-off-by: Hiroshi Miura <[email protected]>
|
@t-cordonnier could you check the backport is as same as #1223 that your fix proposal merged into master. |
|
This also backports the fix PR #1231 to respect foreign matches with segmented search. |
|
Since this also includes part of non-yet validated PR 1220 I think we should wait for definitive version related file name before approving this PR. Or we remove this part, validate PR 1251 and backport action about file name later. |
miurahr
commented
Dec 26, 2024
| @@ -47,23 +47,31 @@ | |||
| */ | |||
| public class NearString { | |||
| public enum MATCH_SOURCE { | |||
| MEMORY, TM, FILES | |||
| MEMORY, TM, FILES, TM_SUBSEG | |||
There was a problem hiding this comment.
Suggested change
| MEMORY, TM, FILES, TM_SUBSEG | |
| MEMORY, TM, FILES, SUBSEGMENTS |
| @@ -301,8 +313,8 @@ public void iterate(EntryKey source, TMXEntry trans) { | |||
| String foundSrc = Core.getSegmenter().glue(sourceLang, sourceLang, fsrc, spaces, brules); | |||
| // glue found translations | |||
| String foundTrans = Core.getSegmenter().glue(sourceLang, targetLang, ftrans, spaces, brules); | |||
| processEntry(null, foundSrc, foundTrans, NearString.MATCH_SOURCE.TM, false, 0, "", "", 0, "", | |||
| 0, null); | |||
| processEntry(null, foundSrc, foundTrans, NearString.MATCH_SOURCE.TM_SUBSEG, false, maxPenalty, | |||
There was a problem hiding this comment.
Suggested change
| processEntry(null, foundSrc, foundTrans, NearString.MATCH_SOURCE.TM_SUBSEG, false, maxPenalty, | |
| processEntry(null, foundSrc, foundTrans, NearString.MATCH_SOURCE.SUBSEGMENTS, false, maxPenalty, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport PR #963
Pull request type
Which ticket is resolved?
What does this PR change?
Other information