Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuration options for HTTP access log #149

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Add configuration options for HTTP access log #149

merged 2 commits into from
Dec 19, 2023

Conversation

stigok
Copy link
Collaborator

@stigok stigok commented Dec 18, 2023 •
edited
Loading

@stigok stigok force-pushed the 63-allow-disabling-http-access-log branch from 93ba703 to 0acd655 Compare December 18, 2023 13:58
@stigok stigok mentioned this pull request Dec 18, 2023
Merged
1 task
@stigok stigok marked this pull request as ready for review December 18, 2023 14:01
@stigok stigok requested a review from a team as a code owner December 18, 2023 14:01
@stigok stigok requested review from djbuster, siljekristensen and mhvalby and removed request for a team December 18, 2023 14:01
@Foxboron
Copy link

Drop the first commit in this change.

Conflicts with #148

@stigok stigok force-pushed the 63-allow-disabling-http-access-log branch from 0acd655 to 8c3d9ec Compare December 18, 2023 15:03
Foxboron
Foxboron previously approved these changes Dec 18, 2023
View reviewed changes
@stigok stigok force-pushed the 63-allow-disabling-http-access-log branch from 8c3d9ec to a6f73fb Compare December 18, 2023 15:10
@github-actions GitHub Actions
Copy link
Contributor

Fuzz test failed on a6f73fb. To troubleshoot locally, use the GitHub CLI to download the seed corpus with

gh run download 7249988119 -n testdata

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

Fuzz test failed on a6f73fb. To troubleshoot locally, use the GitHub CLI to download the seed corpus with

gh run download 7249988119 -n testdata

@stigok
Copy link
Collaborator Author

stigok commented Dec 18, 2023

To use slices we need later Go. Bumping to Go 1.21 as that is a good move anyway #152

@stigok stigok force-pushed the 63-allow-disabling-http-access-log branch from a6f73fb to 37a385f Compare December 19, 2023 08:26
@stigok stigok requested a review from Foxboron December 19, 2023 08:43
@stigok stigok merged commit 7c48d2f into main Dec 19, 2023
10 checks passed
@stigok stigok deleted the 63-allow-disabling-http-access-log branch December 19, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Foxboron Foxboron Foxboron approved these changes

@djbuster djbuster Awaiting requested review from djbuster djbuster is a code owner automatically assigned from nrkno/iac-admins

@siljekristensen siljekristensen Awaiting requested review from siljekristensen siljekristensen is a code owner automatically assigned from nrkno/iac-admins

@mhvalby mhvalby Awaiting requested review from mhvalby mhvalby is a code owner automatically assigned from nrkno/iac-admins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stigok @Foxboron