Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent double copy in Dockerfile #150

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Prevent double copy in Dockerfile #150

merged 1 commit into from
Dec 19, 2023

Conversation

stigok
Copy link
Collaborator

@stigok stigok commented Dec 18, 2023 •
edited
Loading

@stigok stigok marked this pull request as ready for review December 18, 2023 14:02
@stigok stigok requested a review from a team as a code owner December 18, 2023 14:02
@stigok stigok requested review from umglurf, martinsolberg and lu-lux and removed request for a team December 18, 2023 14:02
@stigok stigok changed the title Prevent double copy dockerfile Prevent double copy in Dockerfile Dec 18, 2023
Foxboron
Foxboron reviewed Dec 18, 2023
View reviewed changes
pkg/registry/registry.go Outdated
if r.URL.Path == path {
next.ServeHTTP(w, r)
return
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

if slices.Contains(reg.AccessLogIgnoredPaths, r.URL.Path) {
    next.ServeHTTP(w, r)
    return
}

Requires golang.org/x/exp/slices and currently not a stable API.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was adressed and fixed in #149

Foxboron
Foxboron requested changes Dec 18, 2023
View reviewed changes
Copy link

@Foxboron Foxboron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@stigok stigok force-pushed the prevent-double-copy-dockerfile branch from d85cb76 to 2376eae Compare December 19, 2023 08:46
@stigok stigok merged commit 174b188 into main Dec 19, 2023
10 checks passed
@stigok stigok deleted the prevent-double-copy-dockerfile branch December 19, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Foxboron Foxboron Foxboron approved these changes

@umglurf umglurf Awaiting requested review from umglurf umglurf is a code owner automatically assigned from nrkno/iac-admins

@martinsolberg martinsolberg Awaiting requested review from martinsolberg martinsolberg is a code owner automatically assigned from nrkno/iac-admins

@lu-lux lu-lux Awaiting requested review from lu-lux lu-lux is a code owner automatically assigned from nrkno/iac-admins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stigok @Foxboron