Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate to Vite #6357

Closed
wants to merge 1 commit into from
Closed

chore: migrate to Vite #6357

wants to merge 1 commit into from

Conversation

GVodyanov
Copy link
Contributor

@GVodyanov GVodyanov commented Sep 18, 2024

Big thanks to @susnux for helping out

Webpack ✨Vite✨
Dev build 45M 7.7M
Production build 19M 3.7M

This is with map files removed

Signed-off-by: Grigory V <[email protected]>
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.48%. Comparing base (8f52c6b) to head (97b4954).
Report is 31 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #6357       +/-   ##
=============================================
+ Coverage     23.54%   59.48%   +35.93%     
  Complexity      454      454               
=============================================
  Files           247       41      -206     
  Lines         11700     2231     -9469     
  Branches       2213        0     -2213     
=============================================
- Hits           2755     1327     -1428     
+ Misses         8624      904     -7720     
+ Partials        321        0      -321     
Flag Coverage Δ
javascript ?
php 59.48% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GVodyanov GVodyanov force-pushed the chore/migrate-to-vite branch from 7c4eda4 to 97b4954 Compare September 18, 2024 14:16
@GVodyanov
Copy link
Contributor Author

First issue: previewing appointments doesn't have styling

@st3iny
Copy link
Member

st3iny commented Sep 18, 2024

See also #6068. I don't remember exactly but I fixed some regressions there. You could have a look at the differences.

@GVodyanov
Copy link
Contributor Author

See also #6068. I don't remember exactly but I fixed some regressions there. You could have a look at the differences.

Yeah... We did this during Ferdinand's workshop and didn't know that you had already done it 😅

@GVodyanov
Copy link
Contributor Author

GVodyanov commented Oct 7, 2024

Fixed by #6068

@GVodyanov GVodyanov closed this Oct 7, 2024
@st3iny st3iny deleted the chore/migrate-to-vite branch October 8, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants