Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scope global sidebar styles to the app #6081

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Jun 25, 2024

How to reproduce?

  1. Install Talk.
  2. Open a chat room and open the right sidebar.
  3. Observe the header of the right sidebar.

@st3iny st3iny self-assigned this Jun 25, 2024
@st3iny st3iny added bug 2. developing Work in progress 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 25, 2024
@st3iny st3iny requested a review from Antreesy June 25, 2024 15:56
@st3iny st3iny marked this pull request as ready for review June 25, 2024 15:56
@st3iny st3iny added this to the v4.8.0 milestone Jun 25, 2024
@st3iny
Copy link
Member Author

st3iny commented Jun 25, 2024

/backport to stable4.7

@backportbot backportbot bot added the backport-request A backport was requested for this pull request label Jun 25, 2024
Copy link

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, back to normal:
image

@st3iny st3iny enabled auto-merge June 25, 2024 16:24
@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 25, 2024
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.29%. Comparing base (c01de6e) to head (2460c53).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6081   +/-   ##
=========================================
  Coverage     29.29%   29.29%           
  Complexity      914      914           
=========================================
  Files           287      287           
  Lines         13987    13987           
  Branches       2139     2150   +11     
=========================================
  Hits           4098     4098           
+ Misses         9575     9574    -1     
- Partials        314      315    +1     
Flag Coverage Δ
javascript 15.18% <ø> (ø)
php 58.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@st3iny st3iny merged commit aa212ce into main Jun 25, 2024
44 checks passed
@st3iny st3iny deleted the fix/sidebar-style-scoping branch June 25, 2024 18:18
@backportbot backportbot bot removed the backport-request A backport was requested for this pull request label Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants