Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sidebar editor tab scrolling #6087

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Jun 26, 2024

Regression from #6081

The rule specificity changed so some styles were no longer overwritten by nc-vue.

Signed-off-by: Richard Steinmetz <[email protected]>
@st3iny st3iny added this to the v4.8.0 milestone Jun 26, 2024
@st3iny st3iny requested a review from GretaD June 26, 2024 09:33
@st3iny st3iny self-assigned this Jun 26, 2024
Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and it works now

@GretaD GretaD enabled auto-merge June 26, 2024 10:02
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.71%. Comparing base (4ca0dca) to head (9cb56bd).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6087   +/-   ##
=========================================
  Coverage     29.71%   29.71%           
  Complexity      914      914           
=========================================
  Files           287      287           
  Lines         13835    13835           
  Branches       2163     2163           
=========================================
  Hits           4111     4111           
  Misses         9409     9409           
  Partials        315      315           
Flag Coverage Δ
javascript 15.57% <ø> (ø)
php 58.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 26, 2024
@GretaD GretaD merged commit cee68e6 into main Jun 26, 2024
43 checks passed
@GretaD GretaD deleted the fix/scrollabe-edit-sidebar-tabs branch June 26, 2024 10:42
@st3iny
Copy link
Member Author

st3iny commented Jun 28, 2024

/backport to stable4.7

@backportbot backportbot bot added the backport-request A backport was requested for this pull request label Jun 28, 2024
@backportbot backportbot bot removed the backport-request A backport was requested for this pull request label Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Feature: Editor
Projects
Development

Successfully merging this pull request may close these issues.

2 participants