Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getmodels: download from GitHub #72

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

alexsavulescu
Copy link
Member

@alexsavulescu alexsavulescu commented Jan 9, 2023

Rely on GitHub repositories instead of ModelDB for downloading.
This PR shall live on until we iron out #71? I'm inclined to merge without.

@alexsavulescu alexsavulescu marked this pull request as ready for review May 30, 2023 12:18
@olupton
Copy link
Collaborator

olupton commented May 30, 2023

Did you look into the errors in https://github.com/alexsavulescu/nrn-modeldb-ci/actions/runs/5118249186 ?

I am reluctant to switch to using a source that is known to be problematic (#71) and not to be eagerly updated (issues with new models in the last ~week)...

@alexsavulescu
Copy link
Member Author

Did you look into the errors in https://github.com/alexsavulescu/nrn-modeldb-ci/actions/runs/5118249186 ?

Haven't checked that, there is a cache overlap somehow.

I am reluctant to switch to using a source that is known to be problematic (#71) and not to be eagerly updated (issues with new models in the last ~week)...

In principle we should have the same content GH vs ModelDB, and I'd rather move to GH where we know can leverage things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants