Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDB_MODEL_DOWNLOAD_URL needs to be updated #82

Closed
ramcdougal opened this issue May 26, 2023 · 6 comments · Fixed by #88
Closed

MDB_MODEL_DOWNLOAD_URL needs to be updated #82

ramcdougal opened this issue May 26, 2023 · 6 comments · Fixed by #88
Assignees

Comments

@ramcdougal
Copy link
Member

In modeldb/modeldb.py, MDB_MODEL_DOWNLOAD_URL is set to pull from the Yale site. This link will become inoperative at somepoint in June.

Instead of pulling all the data and metadata about a model to get the file contents, going forward download_model can get the file contents direclty via links of the form https://modeldb.science/eavBinDown?o={model_id}

@alexsavulescu
Copy link
Member

The idea is to use GitHub to download models: #72

@neuronsimulator neuronsimulator deleted a comment from alexsavulescu May 30, 2023
@alexsavulescu
Copy link
Member

However we still have #71

@olupton
Copy link
Collaborator

olupton commented May 30, 2023

To avoid the very-high-latency cache setup we have at the moment, we need a way of efficiently getting the list of models to be tested and some kind of last-updated timestamp or commit ID. I believe this is well within the limits of the GitHub API.

@alexsavulescu
Copy link
Member

something like : #47 (comment)

@olupton
Copy link
Collaborator

olupton commented Jun 20, 2023

Based on https://modeldb.science/api it looks like the results of https://modeldb.science/api/v1/models/id?modeling_application=NEURON and https://modeldb.science/api/v1/models/ver_date?modeling_application=NEURON could be zipped together to get a list of (id, date) pairs.

It seems "reasonable" to assume that these two queries will return results sorted by some common key, so it is safe to zip them together, but I don't see it documented that this is the case. Can you confirm @ramcdougal?

@ramcdougal
Copy link
Member Author

ramcdougal commented Jun 21, 2023

Yes, the two responses are in the same order, and the API documentation on ModelDB.science has been updated to reflect this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants