Do not fail tag datagen when removing IDs not present at runtime #1798
+6
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This is queued to be merged after #1799 as that removes the EFH entirely, possibly superseding this PR. |
|
Right, but that PR targets the latest version as opposed to 1.21.1. Are you suggesting that the EFH removal would also likely be backported to 1.21.1 in place of this? |
embeddedt
reviewed
Dec 27, 2024
|
Previous comment by @marchermans was mistaken (asked via Discord), as this PR is for 1.21.1 while the ExistingFileHelper changes are in 1.21.4. As those changes will not be backported due to their compatibility-breaking behavior, this PR can move forward. |
sciwhiz12
added
the
enhancement
embeddedt
approved these changes
Dec 27, 2024
marchermans
approved these changes
Dec 27, 2024
|
🚀 This PR has been released as NeoForge version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing on from the discussion on (the now seemingly redundant PR) #1794, this PR allows Tag data generation in 1.21.1 to proceed as normal in the event that the
ITagAppenderExtension::removemethods are used with IDs which may not exist at runtime, bypassing theExistingFileHelperchecks for such IDs should they be marked as removal entries.