Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add musicDiscItem Method to ItemModelProvider #1588

Closed
wants to merge 1 commit into from

Conversation

JT122406
Copy link
Contributor

No description provided.

@neoforged-pr-publishing
Copy link

  • Publish PR to GitHub Packages

@sciwhiz12 sciwhiz12 added enhancement New (or improvement to existing) feature or request 1.21.3 Targeted at Minecraft 1.21.3 labels Nov 18, 2024
@neoforged-automation
Copy link

@JT122406, this pull request has conflicts, please resolve them for this PR to move forward.

@sciwhiz12
Copy link
Member

sciwhiz12 commented Dec 24, 2024

Superseded by #1725, with the switch to vanilla's model generation. Use ModelTemplates.MUSIC_DISC as the model template when generating the item model.

@sciwhiz12 sciwhiz12 closed this Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.3 Targeted at Minecraft 1.21.3 enhancement New (or improvement to existing) feature or request needs rebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants