-
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.21.4] Expose vanilla model generators for modded usages #1725
[1.21.4] Expose vanilla model generators for modded usages #1725
Conversation
Last commit published: 2d4f8a00cce8bd87a311150b8bb3ba5f73bf72d8. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #1725' // https://github.com/neoforged/NeoForge/pull/1725
url 'https://prmaven.neoforged.net/NeoForge/pr1725'
content {
includeModule('net.neoforged', 'testframework')
includeModule('net.neoforged', 'neoforge')
}
}
} MDK installationIn order to setup a MDK using the latest PR version, run the following commands in a terminal. mkdir NeoForge-pr1725
cd NeoForge-pr1725
curl -L https://prmaven.neoforged.net/NeoForge/pr1725/net/neoforged/neoforge/21.4.111-beta-pr-1725-pr-vanilla-datagen-21.4/mdk-pr1725.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip To test a production environment, you can download the installer from here. |
408ec8a
to
41e1c12
Compare
@ApexModder, this pull request has conflicts, please resolve them for this PR to move forward. |
41e1c12
to
3d04267
Compare
@ApexModder, this PR introduces breaking changes. Compatibility checks
|
This PR should now be ready for view but important note Meaning that the following would change to something like so |
@ApexModder, this pull request has conflicts, please resolve them for this PR to move forward. |
4e6095e
to
b910484
Compare
@ApexModder, this pull request has conflicts, please resolve them for this PR to move forward. |
dced55d
to
0e4ac40
Compare
@ApexModder, this pull request has conflicts, please resolve them for this PR to move forward. |
943368e
to
916a5e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple more comments, primarily about documentation.
When these are adressed, this PR is good to go from my end. The approval and merge has to be done by someone else as this PR adds code I wrote.
patches/net/minecraft/client/data/models/ModelProvider.java.patch
Outdated
Show resolved
Hide resolved
patches/net/minecraft/client/data/models/ModelProvider.java.patch
Outdated
Show resolved
Hide resolved
...main/java/net/neoforged/neoforge/client/model/generators/template/RootTransformsBuilder.java
Outdated
Show resolved
Hide resolved
...main/java/net/neoforged/neoforge/client/model/generators/template/RootTransformsBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/net/neoforged/neoforge/client/model/generators/template/RotationBuilder.java
Show resolved
Hide resolved
src/main/java/net/neoforged/neoforge/client/model/generators/template/RotationBuilder.java
Show resolved
Hide resolved
src/main/java/net/neoforged/neoforge/client/model/generators/template/TransformVecBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/net/neoforged/neoforge/client/model/generators/template/FaceBuilder.java
Show resolved
Hide resolved
src/main/java/net/neoforged/neoforge/client/model/generators/template/FaceBuilder.java
Show resolved
Hide resolved
Add jdoc to `CustomLoaderBuilder#copy` stating that it must a deep-copy of the current builder instance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some quick comments based on my previous ones.
patches/net/minecraft/client/data/models/BlockModelGenerators.java.patch
Show resolved
Hide resolved
src/main/java/net/neoforged/neoforge/client/model/generators/template/CustomLoaderBuilder.java
Show resolved
Hide resolved
Review went stale and requested changes were applied
src/main/java/net/neoforged/neoforge/common/data/ExistingFileHelper.java
Show resolved
Hide resolved
patches/net/minecraft/client/data/models/ModelProvider.java.patch
Outdated
Show resolved
Hide resolved
patches/net/minecraft/client/data/models/ModelProvider.java.patch
Outdated
Show resolved
Hide resolved
patches/net/minecraft/client/data/models/ModelProvider.java.patch
Outdated
Show resolved
Hide resolved
patches/net/minecraft/client/data/models/model/ModelLocationUtils.java.patch
Outdated
Show resolved
Hide resolved
patches/net/minecraft/client/data/models/model/ModelLocationUtils.java.patch
Outdated
Show resolved
Hide resolved
tests/src/main/java/net/neoforged/neoforge/debug/VanillaDataGenTest.java
Outdated
Show resolved
Hide resolved
🚀 This PR has been released as NeoForge version |
Updated version of #1696 for
1.21.4
.While the vanilla providers have been exposed for modded usage, and can be used for more simpler model generation. This is still highly WIP and requires more patches to support our model extensions and generating a model from scratch.