Comms bridge #756
Merged
Comms bridge #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at location would work
trey0
reviewed
Nov 20, 2023
There was a problem hiding this comment.
Thanks for sharing this! Great to see how far it's coming along.
Comments mostly trivial.
I had a hard time understanding how to estimate the memory usage. The 128K per content message buffer allocation could potentially get bad quickly if we aren't careful. But maybe it doesn't matter for ISAAC in the near term if we don't subscribe to high-rate messages.
…obee into comms_bridge
kbrowne15
force-pushed
the
comms_bridge
branch
from
5b6f8c0 to
3897858
Compare
Added an out topic to link entries so one can specify an out topic name if the8y want. Also added code so that all topics don't go to all robots.
The comms bridge was changed to start the dds subscribers and publishers either on start up if specified in the comms bridge configuration file or when the executive calls the enable comms service. This matches how the current astrobee to astrobee bridge works.
kbrowne15
force-pushed
the
comms_bridge
branch
3 times, most recently
from
aa51b37 to
0d1c82b
Compare
kbrowne15
requested review from
trey0,
bcoltin,
marinagmoreira and
rgarciaruiz
bcoltin
reviewed
Jan 16, 2024
marinagmoreira
approved these changes
Jan 17, 2024
rgarciaruiz
approved these changes
Jan 17, 2024
bcoltin
approved these changes
Jan 18, 2024
trey0
approved these changes
Jan 18, 2024
astrobee/config/communications/dds_generic_comms/NDDS_DISCOVERY_PEERS
Outdated
Show resolved
Hide resolved
| @@ -71,11 +71,11 @@ echo " Analysing python code style with 'isort'." | |||
| # could happen for example if the .isort.cfg src_paths list gets out | |||
| # of date. | |||
|
|
|||
| if $(isort . --extend-skip cmake --profile black --diff --check-only --quiet >/dev/null); then | |||
| if $(isort . --extend-skip cmake,submodules --profile black --diff --check-only --quiet >/dev/null); then | |||
There was a problem hiding this comment.
Interesting. Should we propagate this change to the isaac repo? Not sure why the relevant commands are different.
https://github.com/nasa/isaac/blob/develop/scripts/git/pre-commit.linter_python#L75-L79
There was a problem hiding this comment.
(To answer my own question: "Yes." nasa/isaac#123 )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the comms bridge that allows any ros message to be sent between robots without having to specifically add ros to dds and vice versa code.