Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace cookiecutter with Copier #7

Merged
merged 16 commits into from
Jul 11, 2024
Merged

Conversation

GenevieveBuckley
Copy link
Contributor

Replaces napari/cookiecutter-napari-plugin#190 (at Juan's request, we are moving the PR back to this repo again)

@GenevieveBuckley
Copy link
Contributor Author

I don't know why the Windows python 3.10 CI check just failed - the only information we get is "Subprocess failed", which could mean literally anything failed after a new plugin repo was created and tox run on it. It would be much better if we could make the actual error message that caused it visible.

I'm hoping it's a flaky test. I'll re-run it.

All the CI checks for https://github.com/napari/cookiecutter-napari-plugin/pull/190/checks passed, and this repo should now be in an equivalent state. Also the other Windows CI checks are passing, as are the other python 3.10 checks.

@jni
Copy link
Member

jni commented Jul 11, 2024

Thanks @GenevieveBuckley!

On windows it could just be a flaky runner even. 😬 hopefully it just passes. 🤞

@GenevieveBuckley
Copy link
Contributor Author

On windows it could just be a flaky runner even. 😬 hopefully it just passes. 🤞

Looks like you were right, it's passed now 🎉

@jni jni merged commit c0c821e into napari:main Jul 11, 2024
12 checks passed
@jni
Copy link
Member

jni commented Jul 11, 2024

🚀

jni pushed a commit to napari/docs that referenced this pull request Jul 11, 2024
# References and relevant issues

Pair PR to ~~napari/cookiecutter-napari-plugin#190~~
napari/napari-plugin-template#7

# Description

This PR removes all references to cookiecutter (except in
past release notes), and replaces them with references to
the `napari-plugin-template` repository.

This is so that when we merge PR
napari/napari-plugin-template#7 switching the template
engine from cookiecutter to copier, the napari docs will
match.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants