Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace cookiecutter references with napari-plugin-template #427

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

GenevieveBuckley
Copy link
Contributor

@GenevieveBuckley GenevieveBuckley commented Jun 13, 2024

References and relevant issues

Pair PR to napari/cookiecutter-napari-plugin#190 napari/napari-plugin-template#7

Description

This PR removes all references to cookiecutter (except in past release notes), and replaces them with references to the napari-plugin-template repository.

This is so that when we merge PR napari/napari-plugin-template#7 switching the template engine from cookiecutter to copier, the napari docs will match.

Copy link
Contributor

@DragaDoncila DragaDoncila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me! There will be lots of references to the cookiecutter outside our docs, so it would be good to make sure running the old command gives some meaningful info to the user. I've opened an issue on the cookiecutter repo to track

@melissawm melissawm added this to the 0.5.0 milestone Jun 14, 2024
Copy link
Member

@melissawm melissawm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I grep'd just to be sure and don't see any other mentions of "cookie" 😄

@GenevieveBuckley
Copy link
Contributor Author

Reminder: this should get merged at the same time as napari/cookiecutter-napari-plugin#190

@psobolewskiPhD
Copy link
Member

psobolewskiPhD commented Jun 20, 2024

You can put in your opening post:

Depends on https://github.com/napari/cookiecutter-napari-plugin/pull/190

and merging will be blocked by the GitHub action.

If adding later, you need to re-run the action: https://github.com/napari/docs/actions/runs/9496189460/job/26170036996?pr=427

@jni jni merged commit a73c43d into napari:main Jul 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants