Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Bool::negate, avoid usage like x.not() #1324

Closed
wants to merge 2 commits into from
Closed

add Bool::negate, avoid usage like x.not() #1324

wants to merge 2 commits into from

Conversation

Yoorkin
Copy link
Collaborator

@Yoorkin Yoorkin commented Dec 13, 2024

We will introduce the not x syntax to avoid the illusion of LLM. For any code written like not(x) or not x, it will not break, except for x.not(). This PR remove usage like x.not() in core and introduces the Bool::negate method.

@coveralls
Copy link
Collaborator

coveralls commented Dec 13, 2024

Pull Request Test Coverage Report for Build 4210

Details

  • 14 of 14 (100.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 80.85%

Totals Coverage Status
Change from base Build 4204: 0.04%
Covered Lines: 4509
Relevant Lines: 5577

💛 - Coveralls

@Yoorkin Yoorkin requested a review from bobzhang December 13, 2024 08:53
@Yoorkin Yoorkin marked this pull request as draft December 13, 2024 09:03
@Yoorkin Yoorkin changed the title add Bool::negate, change Bool::not to a regular function add Bool::negate, avoid usage like x.not() Dec 13, 2024
@Yoorkin Yoorkin marked this pull request as ready for review December 13, 2024 10:20
@Yoorkin
Copy link
Collaborator Author

Yoorkin commented Dec 16, 2024

#1330

@Yoorkin Yoorkin marked this pull request as draft December 17, 2024 09:01
@Yoorkin Yoorkin closed this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants