Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(array): Impl eachi, all, any, contains for ArrayView #1326

Merged
merged 4 commits into from
Dec 15, 2024
Merged

feat(array): Impl eachi, all, any, contains for ArrayView #1326

merged 4 commits into from
Dec 15, 2024

Conversation

FlammeShadow
Copy link
Contributor

@coveralls
Copy link
Collaborator

coveralls commented Dec 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 4214

Details

  • 6 of 7 (85.71%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 81.178%
Changes Missing Coverage Covered Lines Changed/Added Lines %
array/view.mbt 6 7 85.71%
Totals Coverage Status
Change from base Build 4213: 0.005%
Covered Lines: 4533
Relevant Lines: 5584
💛 - Coveralls

gmlewis
gmlewis reviewed Dec 14, 2024
View reviewed changes
array/view.mbt Outdated Show resolved Hide resolved
array/view.mbt Show resolved Hide resolved
gmlewis
gmlewis approved these changes Dec 14, 2024
View reviewed changes
Copy link
Contributor

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @FlammeShadow !
LGTM.

@bobzhang bobzhang merged commit 9f8c715 into moonbitlang:main Dec 15, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmlewis gmlewis gmlewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FlammeShadow @coveralls @gmlewis @bobzhang