Revamp hub issue commands

[mislav]

This marks hub issue family of commands coming out of beta.

• hub issue cleaner output

  • doesn't include pull requests
  • red/green color based on closed/open state
  • list both open and closed issues with hub issue -s all
  

• All commands reimplemented using simpleApi and not go-octokit

• hub issue create small tweaks for compatibility with hub release create

Todo:

• Implement other hub issue filtering options
  • Add hub issue --format=... option to choose which fields to output a la git log
• List all pages of results from API (currently consuming just 1st page)
  • Cache previously fetched pages locally
• hub issue edit command to change labels, assignee, closed/open state
  • hub issue comment command to add a comment to the thread?
• Ability to list all your issues a la Issues Dashboard, i.e. not project-specific?
• Flag to specify a repository to manage issues for, e.g. if not in a git working directory?

[pcorpet]

I believe Usage and Long of subcommand are never used. Actually putting something in there can be misleading.

[mislav]

Usage should be displayed in cases when you passed an invalid flag, and Usage and Long are both used for generating documentation for a command.

[pcorpet]

Usage and Long are both used for generating documentation for a command.

That is not true today for subcommands: either open an issue to make hub help issue create display the help for the subcommand, or just remove the doc here.

[mislav]

Oops, you're right. For subcommands, these fields aren't consulted yet. For now, let's keep them up to date still, at least as some sort of "code" documentation, and we'll figure out how to hook subcommands into the global help system.

[krlmlr]

I can confirm that this PR also works with Ubuntu 15.10 (where hub 2.2.3 failed to retrieve anything). Sweet, thanks!

[mislav]

@pcorpet I've pushed some extra features and will merge this to master as the first iteration of the new issue command. Additional upgrades should come in form of separate PRs.

• Add multiple assignees & milestone support
• Add hub issue create --browse flag
• --format placeholders renamed & expanded (see below)
• All pages of API results now fetched. We'll have to figure out some caching strategy.

%I: issue number

%i: issue number prefixed with "#"

%U: the URL of this issue

%S: state (i.e. "open", "closed")

%sC: set color to red or green, depending on issue state.

%t: title

%l: colored labels

%L: raw, comma-separated labels

%b: body

%au: login name of author

%as: comma-separated list of assignees

%Mn: milestone number

%Mt: milestone title

%NC: number of comments

%Nc: number of comments wrapped in parentheses, or blank string if zero.

%cD: created date-only (no time of day)

%cr: created date, relative

%ct: created date, UNIX timestamp

%cI: created date, ISO 8601 format

%uD: updated date-only (no time of day)

%ur: updated date, relative

%ut: updated date, UNIX timestamp

%uI: updated date, ISO 8601 format

[pcorpet]

Cool, thanks. Do you have an idea of a feature / issue I could help with to get a new release of hub with the code currently in master? (I saw you created a 2.2.5 but it seems to cherry-pick only some small fixes).

[mislav]

Do you have an idea of a feature / issue I could help with to get a new release of hub with the code currently in master?

Your help is greatly appreciated. Here are my ideas for the next release: #1232

Obviously, not everything will probably make it in. I'm leaving on vacation for 2 weeks next week, so by the end of this week I was thinking to try to push a prerelease with the stuff currently in master.