-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new subcommand git pull-request info
#1109
Conversation
5de188b
to
580a627
Compare
580a627
to
c85826a
Compare
Hi thanks for the big PR, but you didn't explain much about how you would use this feature. I'm going to reject this PR for now not because it's a bad idea, but because it's not the right time to make the implementation for this yet. Let me elaborate:
I hope that makes sense! I'd appreciate your feedback. |
A little more explanation on how I would use this feature: We have a workflow where we use a custom command to merge PR (well actually rebase them on master). This workflow is using a command line (git submit, a custom command for us) that checks multiple things, for instance that the PR is correctly rebased as only one commit on top of master, and others. I wanted to check before submitting that a branch has indeed a PR open on GitHub and that it got at least one "LGTM" comment from someone else than the author. That would make sure that the code has actually been reviewed. I can see why you're rejecting this PR for now, and I'm willing to contribute (I am between jobs at the moment) to make my workflow work soon.
|
I'm glad you asked. Reviewing the PR (the command API, feature-set, docs, implementation) would be great feedback for me. Next, I might need help with the following features, probably best done as separate PRs:
|
I had to update the vendored octokit. I strongly recommend reviewing each commit separately as one is just about updating and the other one about adding the new feature.