Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanced variable handling for object and list types #59

Merged
merged 5 commits into from
Apr 11, 2024
Merged

Enhanced variable handling for object and list types #59

merged 5 commits into from
Apr 11, 2024

Conversation

DamianCzajkowski
Copy link
Contributor

@DamianCzajkowski DamianCzajkowski commented Apr 10, 2024 •
edited
Loading

Fixes 56

@DamianCzajkowski DamianCzajkowski self-assigned this Apr 10, 2024
@DamianCzajkowski DamianCzajkowski linked an issue Apr 10, 2024 that may be closed by this pull request
Variables not being proxied #56
Closed
@DamianCzajkowski DamianCzajkowski requested a review from rafalp April 10, 2024 10:56
@DamianCzajkowski DamianCzajkowski changed the title fixed-variables-process-to-handle-objects-and-list-variables Enhanced variable handling for object and list types Apr 10, 2024
@rafalp
Copy link
Contributor

rafalp commented Apr 10, 2024

So what was the bug there?

@DamianCzajkowski
Copy link
Contributor Author

So what was the bug there?

The bug was that we didn't handle nested usage of variables in query arguments.

rafalp
rafalp suggested changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@rafalp rafalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing changelog entry.

@DamianCzajkowski DamianCzajkowski requested a review from rafalp April 11, 2024 07:56
rafalp
rafalp reviewed Apr 11, 2024
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@rafalp rafalp merged commit d6c3968 into main Apr 11, 2024
2 checks passed
@rafalp rafalp deleted the 56-variables-not-being-proxied branch April 11, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafalp rafalp rafalp approved these changes

Assignees

@DamianCzajkowski DamianCzajkowski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Variables not being proxied
2 participants
@DamianCzajkowski @rafalp